a few typos #19
Open
a few typos #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a handful of lil typos found while typechecking the codebase. despite them being obvious typos, I did not apply these changes to master because the fix might break things: - `new Date().time` doesn't exist, so the check was always failing and returning stats even if they are stale. fixing the typo makes it return `null` when stats are stale, as intended. - an attribute was named `maxa` instead of `max`. fixing it could break code relying on the typo.
murillo128
reviewed
Aug 20, 2024
| @@ -64,8 +64,8 @@ class VideoEncoder extends Emitter | |||
| const scaleResolutionToHeight = params.scaleResolutionToHeight ? parseInt(params.scaleResolutionToHeight) : 0; | |||
| const allowedDownScaling = scaleResolutionToHeight && params.hasOwnProperty("allowSameHeight")? (params.allowSameHeight ? 1 : 2) : 0; | |||
| //Get default for width and heights | |||
| const width = parseInt(params.width) ? parseInt(params.width) : (scaleResolutionDownBy ? 640 : 0); | |||
| const height = parseInt(params.height) ? parseInt(params.height) : (scaleResolutionDownBy ? 480 : 0); | |||
| const width = params.width ? parseInt(params.width) : (scaleResolutionDownBy ? 640 : 0); | |||
There was a problem hiding this comment.
we need to sanitize input data, iirc swig crashes if wrong type is used
Suggested change
| const width = params.width ? parseInt(params.width) : (scaleResolutionDownBy ? 640 : 0); | |
| const width = parseInt(params.width) ?? 0; |
There was a problem hiding this comment.
your suggestion removes the default of 640, are you sure we want that?
There was a problem hiding this comment.
I think that should be the ultimate goal, we can be consertative and just do this instead
Suggested change
| const width = params.width ? parseInt(params.width) : (scaleResolutionDownBy ? 640 : 0); | |
| const width = parseInt(params.width) ?? (scaleResolutionDownBy ? 640 : 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a handful of lil typos found while typechecking the codebase. despite them being obvious typos, I did not apply these changes to master because the fix might break things:
new Date().timedoesn't exist, so the check was always failing and returning stats even if they are stale. fixing the typo makes it returnnullwhen stats are stale, as intended.an attribute was named
maxainstead ofmax. fixing it could break code relying on the typo.